From fcf945748b9a4a7e3c5d8b5bdbfc595fec4382e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gardais=20J=C3=A9r=C3=A9my?= Date: Wed, 19 Feb 2020 15:24:41 +0100 Subject: [PATCH] Fix useless use of cat MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit https://github.com/koalaman/shellcheck/wiki/SC2002 https://en.wikipedia.org/wiki/Cat_(Unix)#Useless_use_of_cat See also : https://github.com/koalaman/shellcheck/wiki/SC2189 --- xymon/plugins/client/ext/smart | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xymon/plugins/client/ext/smart b/xymon/plugins/client/ext/smart index fd65cb4..2e0c13d 100755 --- a/xymon/plugins/client/ext/smart +++ b/xymon/plugins/client/ext/smart @@ -42,11 +42,11 @@ do echo "" >>/tmp/dres done < /tmp/dscan >/tmp/dcheck -COLOR=$(cat /tmp/dcheck | awk '{print $1}' | sort | uniq | head -1 | cut -c3-) +COLOR=$(< /tmp/dcheck awk '{print $1}' | sort | uniq | head -1 | cut -c3-) $XYMON $XYMSRV "status ${MACHINE}.smart ${COLOR} SMART health check -$(cat /tmp/dcheck | cut -c2-) +$(< /tmp/dcheck cut -c2-) ==================== Detailed status ==================== @@ -56,4 +56,3 @@ $(cat /tmp/dres) rm -f /tmp/dres /tmp/dcheck /tmp/dscan exit 0 -