From cbf0d8afb0df14f7c84e278fdcd637e4363db548 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gardais=20J=C3=A9r=C3=A9my?= Date: Wed, 19 Feb 2020 16:00:36 +0100 Subject: [PATCH] Comment and small fixes --- xymon/plugins/client/ext/smart | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/xymon/plugins/client/ext/smart b/xymon/plugins/client/ext/smart index 2e0c13d..c433436 100755 --- a/xymon/plugins/client/ext/smart +++ b/xymon/plugins/client/ext/smart @@ -3,22 +3,24 @@ # NOTE: Must be run as root, so you probably need to setup sudo for this. if test -f /tmp/dres; then rm -f /tmp/dres; fi +if test -f /tmp/dscan; then rm -f /tmp/dscan; fi +# Get the list of all available devices smartctl --scan > /tmp/dscan -# MODIFY below to match your setup - the "scsi-SATA" is pretty generic, but you -# can add more disks if you like. E.g. I have a USB disk permanently plugged in. - -while read LINE -do +while IFS= read -r LINE; do + ## Get device and type DISK=$(echo "${LINE}" | cut -d" " -f1) TYPE=$(echo "${LINE}" | cut -d" " -f3) + + ## Get SMART Health Status and return code DRES=$(/usr/sbin/smartctl -H -d "${TYPE}" -n standby "${DISK}") DCODE=$? DSTBY=$(( DCODE & 2 )) DFAIL=$(( DCODE & 8 )) DWARN=$(( DCODE & 32 )) + ## Give a weight to each to color to easily get the page status if test $DSTBY -ne 0 then COLOR="4&clear" @@ -36,15 +38,16 @@ do echo "${COLOR} $DISK ${TYPE}" | cut -c2- >>/tmp/dres echo "" >>/tmp/dres - echo "$DRES" | egrep -v "^smartctl|^Copyright|^$|^===" >>/tmp/dres + echo "$DRES" | grep -v -E "^smartctl|^Copyright|^$|^===" >>/tmp/dres echo "------------------------------------------------------------" >>/tmp/dres echo "" >>/tmp/dres echo "" >>/tmp/dres done < /tmp/dscan >/tmp/dcheck +# Set the global color according to the highest alert COLOR=$(< /tmp/dcheck awk '{print $1}' | sort | uniq | head -1 | cut -c3-) -$XYMON $XYMSRV "status ${MACHINE}.smart ${COLOR} SMART health check +$XYMON "${XYMSRV}" "status ${MACHINE}.smart ${COLOR} SMART health check $(< /tmp/dcheck cut -c2-)