From 134640f4737f6d644ec918f3d3b83173c2b3d009 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gardais=20J=C3=A9r=C3=A9my?= Date: Wed, 1 Sep 2021 11:52:45 +0200 Subject: [PATCH] Truthy warnings with ansible-lint --- CHANGELOG.md | 1 + README.md | 2 +- defaults/main.yml | 6 +++--- tasks/main.yml | 6 +++--- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d23d349..72d109a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ### Fix * Use key_url instead of [deprecated SKS keyserver](https://sks-keyservers.net/). +* Truthy warnings with ansible-lint. ### Enhancements diff --git a/README.md b/README.md index a5b7567..86f96c7 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,7 @@ A role to manage OpenManage (via omreport, omconfig,…), it's web interface OMS * **openmanage__repositories** : List of APT repositories that can provide OpenManage. Each entry is a dict [default : `See default/main.yml`]. * **openmanage__deploy_state** : The desired state this role should achieve [default for Dell hardware : `present`]. -* **openmanage__install_recommends** : If recommended packages should be install [default : `False`]. +* **openmanage__install_recommends** : If recommended packages should be install [default : `false`]. * **openmanage__dep_packages** : List of dependencies packages to be able to run racadm [default : `See default/main.yml`]. * **openmanage__base_packages** : List of base packages for all racadm base usage [default : `See default/main.yml`]. * **openmanage__stretch_packages** : List of some packages specific to Debian Stretch (or Ubuntu Xenial) and previous versions [default : `See default/main.yml`]. diff --git a/defaults/main.yml b/defaults/main.yml index 9c3608b..85b936c 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -77,12 +77,12 @@ openmanage__deploy_state: '{{ "present" # # If recommended packages should be install ? Possible options : # -# ``False`` +# ``false`` # Default. # -# ``True`` +# ``true`` # -openmanage__install_recommends: False +openmanage__install_recommends: false # ]]] # .. envvar:: openmanage__dep_packages [[[ # diff --git a/tasks/main.yml b/tasks/main.yml index a23c2b7..ea6dd51 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -7,7 +7,7 @@ ## Add repository - name: Add OpenManage repository apt_repository: - update_cache: False + update_cache: false repo: '{{ item.repo }}' mode: '{{ item.mode | d(omit) }}' filename: '{{ item.filename | d(omit) }}' @@ -34,11 +34,11 @@ ## Update cache - name: Update APT cache apt: - update_cache: '{{ True + update_cache: '{{ true if (openmanage__register_key is changed or openmanage__register_repositories is changed) else - False }}' + false }}' register: openmanage__register_update until: openmanage__register_update is success when: (openmanage__deploy_state == "present")