From 5a9d0cf18485ad1692cab5d40b6caabd12e28c54 Mon Sep 17 00:00:00 2001
From: Guillaume Raffy <guillaume.raffy@univ-rennes1.fr>
Date: Tue, 3 Oct 2017 16:01:03 +0200
Subject: [PATCH] ipmroved documentation and fixed typos

---
 README.md         |  2 +-
 defaults/main.yml |  4 ++--
 meta/main.yml     |  2 +-
 tasks/main.yml    | 16 ++++++++--------
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/README.md b/README.md
index 9dea061..6c157f3 100644
--- a/README.md
+++ b/README.md
@@ -11,7 +11,7 @@
 
 ## Overview
 
-Manage NFS (client) installation and configuration.
+This role manages NFS client installation and configuration using fixed ports.
 
 ## Role Variables
 
diff --git a/defaults/main.yml b/defaults/main.yml
index cabf264..6c82c33 100644
--- a/defaults/main.yml
+++ b/defaults/main.yml
@@ -5,10 +5,10 @@
 nfs_cli_manage: true
 nfs_cli_pkg_state: 'installed'
 nfs_cli_conf_path: '/etc/default/nfs-common'
-nfs_cli_conf_tpl: 'etc/default/nfs-common.j2'
+nfs_cli_conf_tpl: 'etc/default/nfs-common.j2' # TODO : hide this variable from user, this is for this role's internal use
 
 nfs_quota_conf_path: '/etc/default/quota'
-nfs_quota_conf_tpl: 'etc/default/quota.j2'
+nfs_quota_conf_tpl: 'etc/default/quota.j2' # TODO : hide this variable from user, this is for this role's internal use
 
 # rpcbind
 nfs_rpc_nfsd: '2049'
diff --git a/meta/main.yml b/meta/main.yml
index caa04c9..e4f15df 100644
--- a/meta/main.yml
+++ b/meta/main.yml
@@ -1,6 +1,6 @@
 galaxy_info:
   author: "Jérémy Gardais"
-  description: "Manage NFS (client/server) installation and configuration"
+  description: "This role manages NFS client installation and configuration using fixed ports"
   license: WTFPL
   company: IPR
   issue_tracker_url: https://git.ipr.univ-rennes1.fr/cellinfo/ansible.nfs/issues
diff --git a/tasks/main.yml b/tasks/main.yml
index 46ee9af..a5e6d01 100644
--- a/tasks/main.yml
+++ b/tasks/main.yml
@@ -1,23 +1,23 @@
 ---
-# tasks file for nfs
+# tasks file for role nfs
 
-- name: Load specific OS vars for nfs
-  include_vars: "{{ item }}"
+- name: load operating system specific variables for nfs 
+  include_vars: "{{ item }}" # includes yml file containing os specific variable, eg "debian.yml" found in role_root/vars
   with_first_found:
     - "{{ ansible_distribution|lower }}-{{ ansible_distribution_version }}.yml"
     - "{{ ansible_distribution|lower }}.yml"
     - "{{ ansible_os_family|lower }}.yml"
 
 # client {{{
-- name: client package
+- name: ensure nfs client package is in the required install state
   package:
-    name: '{{ item }}'
+    name: '{{ item }}'   # TODO: why not simply {{ nfs_cli_pkg_list }} ?
     state: '{{ nfs_cli_pkg_state }}'
   with_items:
     - '{{ nfs_cli_pkg_list }}'
   when: nfs_cli_manage
 
-- name: CONFIG nfs-client
+- name: configure nfs-client
   template:
     src: '{{ nfs_cli_conf_tpl }}'
     dest: '{{ nfs_cli_conf_path }}'
@@ -27,7 +27,7 @@
     backup: true
   when: nfs_cli_manage
 
-- name: CONFIG nfs-quota
+- name: configure nfs-quota
   template:
     src: '{{ nfs_quota_conf_tpl }}'
     dest: '{{ nfs_quota_conf_path }}'
@@ -37,7 +37,7 @@
     backup: true
   when: nfs_cli_manage
 
-- name: CONFIG add rpcbind services
+- name: declare rpcbind ports in /etc/services
   blockinfile:
     state: present
     insertafter: EOF