From 9c8c181e7064bc7f6ba8d62d76230e5ab5259889 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gardais=20J=C3=A9r=C3=A9my?=
 <jeremy.gardais@univ-rennes1.fr>
Date: Tue, 26 Feb 2019 17:30:43 +0100
Subject: [PATCH] Fix E503 Task that run when changed should likely be handlers

Daemon_reload moved to handlers file.
---
 CHANGELOG.md      | 1 +
 handlers/main.yml | 4 ++++
 tasks/main.yml    | 8 +-------
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index cf79cb5..662cab0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 * Fix E405 Remote package tasks should have a retry.
 * Fix E303 systemctl used in place of systemd module.
+* Fix E503 Tasks that run when changed should likely be handlers. Daemon_reload moved to handlers file.
 
 ## v2.1.1
 
diff --git a/handlers/main.yml b/handlers/main.yml
index feba7e4..b0bdc98 100644
--- a/handlers/main.yml
+++ b/handlers/main.yml
@@ -7,3 +7,7 @@
     enabled: '{{ item.service | d(True) | bool }}'
   with_flattened:
     - '{{ flexlm__licences }}'
+
+- name: systemd daemon reload
+  systemd:
+    daemon_reload: True
diff --git a/tasks/main.yml b/tasks/main.yml
index 39c0b2b..4ddedc6 100644
--- a/tasks/main.yml
+++ b/tasks/main.yml
@@ -87,17 +87,11 @@
     owner: 'root'
     group: 'root'
     mode: '0644'
-  register: flexlm__register_service
   with_flattened:
     - '{{ flexlm__licences }}'
   when: ( (flexlm__deploy_state == "present") and
         ( item.service | d(True) ))
-
-- name: Force systemd to reread configs
-  systemd:
-    daemon_reload: True
-  notify: ['restart flexlm services']
-  when: ( flexlm__register_service|changed )
+  notify: ['systemd daemon reload', 'restart flexlm services']
 
 - name: Manage flexlm services
   service: